Re: smgr cleanup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: smgr cleanup
Date: 2004-05-04 03:50:50
Message-ID: 29217.1083642650@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> This patch removes a couple of no-ops.

I object to this change. The fact that these modules don't currently
need to do anything at commit/abort doesn't mean that they never again
will need to. In particular I do not like putting in a blanket
assumption that no smgr module will ever need control at these points.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-05-04 04:17:48 Re: Run-as-admin warning for win32
Previous Message Shachar Shemesh 2004-05-04 02:37:35 Re: Run-as-admin warning for win32