| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling) |
| Date: | 2017-01-17 17:52:20 |
| Message-ID: | 29207.1484675540@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Jan 16, 2017 at 2:13 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> "Srf" is ugly as can be, and unintelligible. SetResult might be OK.
> The operation we're performing here, IIUC, is projection. SetResult
> lacks a verb, although Set could be confused with one; someone might
> think this is the node that sets a result, whatever that means.
> Anyway, I suggest working Project in there somehow. If Project by
> itself seems like it's too generic, perhaps ProjectSet or
> ProjectSetResult would be suitable.
Andres' patch is already using "SetProjectionPath" for the path struct
type. Maybe make that "ProjectSetPath", giving rise to a "ProjectSet"
plan node?
I'm happy to do a global-search-and-replace while I'm reviewing the
patch, but let's decide on names PDQ.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-01-17 17:57:33 | Re: Parallel Index Scans |
| Previous Message | Stephen Frost | 2017-01-17 17:47:08 | Re: Improving RLS planning |