From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Joe Van Dyk <joe(at)tanga(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: ltree::text not immutable? |
Date: | 2014-11-04 23:48:14 |
Message-ID: | 29132.1415144894@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
I wrote:
> An alternative that just occurred to me is to put the no-volatile-
> I/O-functions check into CREATE TYPE, but make it just WARNING not
> ERROR. That would be nearly as good as an ERROR in terms of nudging
> people who'd accidentally omitted a volatility marking from their
> custom types. But we could leave chkpass as-is and wait to see if
> anyone complains "hey, why am I getting this warning?". If we don't
> hear anyone complaining, maybe that means we can get away with changing
> the type's behavior in 9.6 or later.
Attached is a complete patch along these lines. As I suggested earlier,
this just makes the relevant changes in ltree--1.0.sql and
pg_trgm--1.1.sql without bumping their extension version numbers,
since it doesn't seem important enough to justify a version bump.
I propose that we could back-patch the immutability-additions in ltree and
pg_trgm, since they won't hurt anything and might make life a little
easier for future adopters of those modules. The WARNING additions should
only go into HEAD though.
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
warn-for-volatile-io-functions.patch | text/x-diff | 14.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2014-11-05 06:09:15 | Re: BUG #11872: row height is not quite tall eneough |
Previous Message | Bernd Helmle | 2014-11-04 23:14:42 | Re: [GENERAL] Re: [BUGS] COPY TO returning empty result with parallel ALTER TABLE |
From | Date | Subject | |
---|---|---|---|
Next Message | Marko Tiikkaja | 2014-11-04 23:48:57 | to_char_at_timezone()? |
Previous Message | Bernd Helmle | 2014-11-04 23:14:42 | Re: [GENERAL] Re: [BUGS] COPY TO returning empty result with parallel ALTER TABLE |