Re: Window Functions with identical PARTITION BY and ORDER BY clauses evaluated separately

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Christopher Inokuchi <cinokuchi(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: Window Functions with identical PARTITION BY and ORDER BY clauses evaluated separately
Date: 2025-03-08 19:50:52
Message-ID: 29119.1741463452@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

"David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> On Fri, Mar 7, 2025 at 5:05 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Perhaps the wording in section 7.2.5 could be improved; I agree
>> that "evaluated in one pass" is capable of being read in more
>> than one way, and it's not clear that it's referring to sorts.
>> Do you have any suggestions for clearer wording?

> We seem to do quite a few things that we don't tell the user about. The
> attached patch describes those things and adds an example demonstrating
> their effects via an explain; which is the only way you can construct an
> example for this material.
> Considered a draft pending feedback to either throw it out in favor of a
> one-word/one-line fix or support for going into this amount of detail.

Meh. This is detail that wasn't asked for and doesn't belong in this
section anyway. (If we did want to write something like this, chapter
14 Performance Tips would be a more plausible home I think. That'd
at least remove the problem of forward-referencing EXPLAIN output.)

For a shorter fix, maybe replace the first two sentences

When multiple window functions are used, all the window functions
having syntactically equivalent PARTITION BY and ORDER BY clauses
in their window definitions are guaranteed to be evaluated in a
single pass over the data. Therefore they will see the same sort
ordering, even if the ORDER BY does not uniquely determine an
ordering.

with

When multiple window functions are used, all the window functions
having syntactically equivalent PARTITION BY and ORDER BY clauses
in their window definitions are guaranteed to see the same
ordering of the input rows, even if the ORDER BY does not uniquely
determine the ordering.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message David G. Johnston 2025-03-09 01:07:26 Re: Window Functions with identical PARTITION BY and ORDER BY clauses evaluated separately
Previous Message Marcin Wisnicki 2025-03-08 19:32:23 Re: BUG #18836: Cannot import foreign schema under different schema name when foreign table uses row types