Re: thread_test.c problems

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: wespvp(at)syntegra(dot)com, joseph speigle <joe(dot)speigle(at)jklh(dot)us>, PostgreSQL <pgsql-general(at)postgresql(dot)org>
Subject: Re: thread_test.c problems
Date: 2004-04-05 02:21:25
Message-ID: 29117.1081131685@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> wespvp(at)syntegra(dot)com wrote:
> have you tried adding a volatile keyword to the
> int volatile errno1_set = 0;
> int volatile errno2_set = 0;
>
> I have applied the following patch to CVS head which does a getpid() in
> the loop, rather than nothing.

That does not cure the bug identified by wespvp. It may make it a
little less likely that the compiler will choose to optimize out the
loop test, but only adding "volatile" really fixes the problem in
a language-standard-compliant way.

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Bruce Momjian 2004-04-05 02:23:24 Re: thread_test.c problems
Previous Message Bruce Momjian 2004-04-05 01:28:05 Re: thread_test.c problems

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-04-05 02:23:24 Re: thread_test.c problems
Previous Message Bruce Momjian 2004-04-05 01:28:05 Re: thread_test.c problems