Re: BUG #11335: an invalid prepare statement causes crash at log_statement = 'mod' or 'ddl'.

I wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> On Sat, Sep 6, 2014 at 1:34 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>>> On 2014-09-06 16:25:28 -0400, Tom Lane wrote:
>>>> I don't think this fix is either appropriate or adequate.

>>> Agreed (and commented offlist. Which probably was a mistake).

>> This has not been reverted yet. Wouldn't it be better to do that asap?

> Probably not until someone codes a better fix. I have it on my plate
> to look into a better fix, but I've been horribly busy lately.

I've applied a fix that takes the approach of explicitly testing for
null plancache->raw_parse_tree whereever necessary. There were at least
two places where there was no such test before; I think they are probably
unreachable with an empty query (because no replanning could ever be
needed) but it seems best to be consistent.

regards, tom lane