Re: buildfarm git references pointing at github?

On 03/14/2017 11:14 AM, Alvaro Herrera wrote:
> Andrew Dunstan wrote:
>>
>> On 03/14/2017 10:45 AM, Alvaro Herrera wrote:
>>> Andrew Dunstan wrote:
>>>
>>>> On 03/14/2017 10:15 AM, Tom Lane wrote:
>>>>> I really would rather not be directed to github when
>>>>> checking on our commits.
>>>> I have already changed that except for the case where gitweb provides no
>>>> equivalent functionality (the "Change set" links).
>>> https://git.postgresql.org/gitweb/?p=postgresql.git;a=shortlog;hp=9e09264;h=9ca5c8721dfa
>> Yes, but you can't get the diff for the whole changeset AFAIK. If you
>> click the commitdiff button for that link it only shows you the diff for
>> one commit. And we're already showing you the summary in the buildfarm
>> web page, so there's not much value in changing it to this.
> Ah, so what you want is this:
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;hp=1e6de941e;h=9ca5c8721dfa
> (I changed the "hp" parent commit to avoid a large diff).
>

That is still only showing me the diff for a single commit AFAICT.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services