NULL handling in exconfig deconstruction

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: NULL handling in exconfig deconstruction
Date: 2018-11-08 13:30:50
Message-ID: 289FFB8B-7AAB-48B5-A497-6E0D41D7BA47@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

In extension_config_remove() we first ensure that pg_extension.extconfig cannot
contain any NULL values in the array, ERRORing out if so. Later we however ask
for NULL values back when deconstructing the array, throwing away the results
knowing there wont be any, which seems superfluous (and wrong if there indeed
were any). The attached patch signals to deconstruct_array() that any NULL
values should be considered an error instead of returned, to keep NULL value
handling consistent (and shave two small allocations off).

cheers ./daniel

Attachment Content-Type Size
extconfig_nulls.patch application/octet-stream 1.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-11-08 13:30:59 Re: move PartitionBoundInfo creation code
Previous Message Alvaro Herrera 2018-11-08 13:29:34 Re: New vacuum option to do only freezing