Re: Dumping roles improvements?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Dumping roles improvements?
Date: 2011-10-12 20:21:41
Message-ID: 28964.1318450901@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Josh Berkus <josh(at)agliodbs(dot)com> writes:
> On 10/11/11 9:43 PM, Tom Lane wrote:
>> I don't find this terribly convincing. I can see the rationales for two
>> endpoint cases: (1) restore these objects into exactly the same
>> ownership/permissions environment that existed before, and (2) restore
>> these objects with the absolute minimum of ownership/permissions
>> assumptions. The latter case seems to me to be covered already by
>> --no-owner --no-privileges.

> But what I'm asking for is (1). The problem is that the roles don't
> ship in the per-database pgdump file.

In that case you do "pg_dumpall -r" first and then pg_dump your
individual database. I thought you were looking for something that
would dump only roles referenced in the particular database, which
is why it sounded like an intermediate case.

I know that the division of labor between pg_dumpall and pg_dump could
use rethinking, but it needs to be actually rethought, in toto, not
hacked one minor feature at a time.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Phil Sorber 2011-10-12 20:22:17 Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c
Previous Message Robert Haas 2011-10-12 19:48:56 Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c