Re: pg_class.relpages/allvisible probably shouldn't be a int4

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_class.relpages/allvisible probably shouldn't be a int4
Date: 2014-05-09 20:37:49
Message-ID: 28830.1399667869@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> That's nothing for 9.4 anymore, but shouldn't we make pg_class.relpages
> a int8 (sounds slightly better than float to me) or somesuch?

No; those are really BlockNumbers, and have always been. float4 would
lose information and float8 or int8 would waste space. If we had an
unsigned int type it'd be better. I suppose we could declare them as OID,
but that would probably confuse people no end.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2014-05-09 20:39:25 Re: Sending out a request for more buildfarm animals?
Previous Message Guillaume Lelarge 2014-05-09 19:24:04 Weird behaviour with the new MOVE clause of ALTER TABLESPACE