Re: Requesting external_pid_file with postgres -C when not initialized lead to coredump

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: alain radix <alain(dot)radix(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Requesting external_pid_file with postgres -C when not initialized lead to coredump
Date: 2016-06-22 16:51:42
Message-ID: 2878.1466614302@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

alain radix <alain(dot)radix(at)gmail(dot)com> writes:
> Another effect of the patch is that it become possible to start a cluster
> with external_pid_file='' in postgresql.conf
> It would have that same behavior as many other parameters.

I'd still be inclined to do that with something along the lines of

- if (external_pid_file)
+ if (external_pid_file && external_pid_file[0])

rather than changing the default per se.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2016-06-22 20:51:46 Re: Reference to UT1
Previous Message Tom Lane 2016-06-22 16:46:37 Re: Parallelized polymorphic aggs, and aggtype vs aggoutputtype