Re: pgsql: Add libpq parameter 'channel_binding'.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add libpq parameter 'channel_binding'.
Date: 2019-09-30 21:41:46
Message-ID: 28779.1569879706@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> Looks good to me, though I think you need to update the expected error
> message in the test you just added.

The test case did pass for me when I tried it on an old-openssl machine
a few hours ago. I don't think this test has any way to exercise the
code path where the server has support and the client doesn't (or
vice versa).

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-09-30 21:51:39 Re: pgsql: pg_rewind: Allow writing recovery configuration
Previous Message Jeff Davis 2019-09-30 21:38:14 Re: pgsql: Add libpq parameter 'channel_binding'.