Re: [PATCHES] ALTER SCHEMA ... SET TABLESPACE

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Philip Warner <pjw(at)rhyme(dot)com(dot)au>
Cc: "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] ALTER SCHEMA ... SET TABLESPACE
Date: 2004-08-23 04:28:48
Message-ID: 28773.1093235328@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Philip Warner <pjw(at)rhyme(dot)com(dot)au> writes:
> At 01:48 PM 23/08/2004, Marc G. Fournier wrote:
>> Won't the dump/restore "store" a "CREATE SCHEMA" onto the new
>> tablespace? Why would a dump/restore issue an ALTER SCHEMA part way through?

> We've had the same problem with CREATE TABLE statements. Tom is (I think)
> working on a SET DEFAULT_TABLESPACE command so that CREATE TABLE no longer
> refers to the tablespace.

There's been some talk of that, but AFAICS it's not related to an ALTER
SCHEMA SET [DEFAULT] TABLESPACE command. (And no, I've not yet lifted
a finger on this, though I'm willing to handle the backend side of it
if there's consensus to handle dumping this way.)

I have mixed emotions about the ALTER SCHEMA patch. It is a pretty
simple and obvious extension --- and we did say that we would cut some
slack on the interpretation of "feature freeze" for stuff related to the
big 7.5/8.0 additions. On the other hand (a) that was two months ago
now, and (b) the recent foulup with the also-simple-and-obvious ALTER
INDEX extension served to remind me why we have a feature-freeze policy
in the first place. I'm kinda leaning to Marc's position at the moment.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dennis Bjorklund 2004-08-23 04:49:33 Re: monetary bug
Previous Message Philip Warner 2004-08-23 03:57:38 Re: [PATCHES] ALTER SCHEMA ... SET TABLESPACE

Browse pgsql-patches by date

  From Date Subject
Next Message Philip Warner 2004-08-23 04:56:58 Re: [PATCHES] ALTER SCHEMA ... SET TABLESPACE
Previous Message Philip Warner 2004-08-23 03:57:38 Re: [PATCHES] ALTER SCHEMA ... SET TABLESPACE