Re: pgsql: Plug more memory leaks when reloading config file.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Plug more memory leaks when reloading config file.
Date: 2014-01-21 16:30:09
Message-ID: 28770.1390321809@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Robert Haas <rhaas(at)postgresql(dot)org> writes:
> Plug more memory leaks when reloading config file.

Hm, not too sure about this hunk:

ereport(LOG,
(errmsg("skipping missing configuration file \"%s\"",
abs_path)));
- return OK;
+ OK = true;
+ goto cleanup;
}

That's changing the semantics, no? That is, what if OK was previously
false? Seems like this coding might be masking an intended failure
report. I'd have expected just "goto cleanup" without changing OK.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2014-01-21 16:38:04 Re: pgsql: Plug more memory leaks when reloading config file.
Previous Message Robert Haas 2014-01-21 15:03:31 pgsql: Avoid a possible relcache leak in get_object_address_attribute.