| From: | Adam Rauch <adam(at)labkey(dot)com> |
|---|---|
| To: | Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com> |
| Cc: | List <pgsql-jdbc(at)postgresql(dot)org> |
| Subject: | Re: 42.2.3 regression in fn timestampadd(SQL_TSI_MINUTE) |
| Date: | 2018-07-15 23:32:11 |
| Message-ID: | 2876ecac-f496-a014-a9ca-bccec77134de@labkey.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
Vladimir, thanks for the prompt fix!
I've confirmed that 42.2.4 works correctly with our unit tests (which
exercise timestampadd using all the standard constants)... i.e., fix
looks great.
Minor issue: I believe there's a typo in the 42.2.3 known issues section
of the changelogs (/CHANGELOG.md and
/docs/_posts/2018-07-12-42.2.3-release.md): I think "SQL_TSI_MINUTE is
treated as minute" should be "SQL_TSI_MINUTE is treated as second".
Thanks!
Adam
On 7/14/2018 3:06 AM, Vladimir Sitnikov wrote:
> Adam, thanks for the prompt report.
>
> Please feel free to review a suggested fix:
> https://github.com/pgjdbc/pgjdbc/pull/1250
>
> Vladimir
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vladimir Sitnikov | 2018-07-16 10:10:45 | [pgjdbc/pgjdbc] 5898cd: docs: typo in 42.2.3 changelog "minute->second" |
| Previous Message | Vladimir Sitnikov | 2018-07-14 15:21:28 | [pgjdbc/pgjdbc] b1507f: docs: escape underscores in changelog otherwise it... |