Re: Possibly a typo in expand_inherited_rtentry()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Possibly a typo in expand_inherited_rtentry()
Date: 2015-04-03 14:01:23
Message-ID: 28754.1428069683@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> writes:
> Attached does:
> - /* Open rel if needed; we already have required locks */
> + /* Open rel if needed; we already have acquired locks */

> Does that make sense?

No, not particularly. It could be made to say "the locks we require"
but I don't find anything wrong with the existing wording (and I'll
bet there is similar wording in many other places).

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-04-03 14:02:08 Re: Abbreviated keys for Numeric
Previous Message Greg Stark 2015-04-03 13:46:45 Re: PATCH: adaptive ndistinct estimator v4