Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Jason Petersen <jason(at)citusdata(dot)com>, pgsql-pkg-debian(at)postgresql(dot)org, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x
Date: 2017-05-31 13:55:31
Message-ID: 28752.1496238931@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-pkg-debian

Christoph Berg <myon(at)debian(dot)org> writes:
> Re: Tom Lane 2017-05-30 <1564(dot)1496176732(at)sss(dot)pgh(dot)pa(dot)us>
>> It'd be interesting if people could gather similar numbers on other
>> platforms of more real-world relevance, such as ppc64. But based on
>> this small sample, I wouldn't object to just going to -fPIC across
>> the board.

> [ more numbers ]

OK, this looks good to me. Just to make sure everyone's on the
same page, what I propose to do is simplify all our platform-specific
Makefiles that use either -fpic or -fPIC to use -fPIC unconditionally.
This affects the netbsd, linux, and openbsd ports. Looks like we should
also change the example link commands in dfunc.sgml.

Next question: should we back-patch this change, or just do it in HEAD?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-05-31 13:57:27 Re: BUG #14680: startup process on standby encounter a deadlock of TwoPhaseStateLock when redo 2PC xlog
Previous Message Robert Haas 2017-05-31 13:40:16 Re: Create subscription with `create_slot=false` and incorrect slot name

Browse pgsql-pkg-debian by date

  From Date Subject
Next Message Christoph Berg 2017-05-31 15:09:40 Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x
Previous Message Christoph Berg 2017-05-31 09:43:38 Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x