Re: \crosstabview fixes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Daniel Verite" <daniel(at)manitou-mail(dot)org>
Cc: "Christoph Berg" <myon(at)debian(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: \crosstabview fixes
Date: 2016-04-14 15:58:09
Message-ID: 28741.1460649489@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> My feeling is that what we should do is undo the change to use OT_SQLID,
> and in indexOfColumn() perform a downcasing/dequoting conversion that
> duplicates what OT_SQLID does in psqlscanslash.l.

Here's an updated patch that does it that way, and also adopts Christoph's
documentation suggestion about "sortcolH". Any further comments?

regards, tom lane

Attachment Content-Type Size
crosstabview-fixes-3.patch text/x-diff 34.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-04-14 16:11:01 Re: Suspicious behaviour on applying XLOG_HEAP2_VISIBLE.
Previous Message Andres Freund 2016-04-14 15:57:38 Re: Pglogical questions and problems