| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: Better way of dealing with pgstat wait timeout during buildfarm runs? |
| Date: | 2015-01-19 17:05:01 |
| Message-ID: | 28560.1421687101@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Jan 19, 2015 at 11:30 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> Sure, but the log isn't invisible. As mentioned one paragraph above, I
>> don't think it's likely to ever be noticed in the client code in the
>> cases where it happens in production.
> Yes, that is my feeling as well.
Meh. I still don't like it, but I guess I'm outvoted. Unless there are
further votes, what we have at this point is just:
- elog(WARNING, "pgstat wait timeout");
+ ereport(LOG, (errmsg("using stale statistics instead of current ones because stats collector is not responding")));
with no conditionality for pgstat_vacuum_stat vs. other callers.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-01-19 17:14:31 | Re: PATCH: Reducing lock strength of trigger and foreign key DDL |
| Previous Message | Andres Freund | 2015-01-19 16:56:55 | Re: Patch: add recovery_timeout option to control timeout of restore_command nonzero status code |