Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Magnus Hagander <mha(at)sollentuna(dot)net>, Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>, pgsql-hackers(at)postgresql(dot)org, Merlin Moncure <merlin(dot)moncure(at)rcsonline(dot)com>
Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
Date: 2005-10-22 18:52:39
Message-ID: 2855.1130007159@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> The hard part looks to be cancelling/changing the timer, which means
> that we can't just create a set and forget listener thread for a given
> timeout. Otherwise that seems to me the straightforward approach.

Yeah. I think probably the cleanest way is to create a persistent
thread that manages the timer. We need a way for the main thread to
tell it to cancel the timer or change the setting. Dunno enough about
Windows' interthread communication primitives to propose details.

> I doubt the changes would be very invasive - with luck just confined to
> timer.c.

I don't see a need for anything else to know about it, either.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2005-10-22 19:46:32 Re: Question about Ctrl-C and less
Previous Message Andrew Dunstan 2005-10-22 18:39:04 Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance