Re: pgmonitor patch for query string

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: The Hermit Hacker <scrappy(at)hub(dot)org>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgmonitor patch for query string
Date: 2001-03-14 18:39:09
Message-ID: 28534.984595149@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The Hermit Hacker <scrappy(at)hub(dot)org> writes:
> I'm saying no because it doesn't fix any known bugs, it *adds* another
> feature ... we are *months* too late in the cycle for that ...

I thought it was a pretty good idea even without any consideration for
Bruce's monitor program. The advantage is that one would be able to
extract the current query from a crashed backend's core dump, even if
the backend had been compiled without debug symbols. Right now you can
only find out the query if you had compiled with debug, because you have
to be able to look at local variables of functions. And there are an
awful lot of people who don't use debug-enabled builds...

Given that and the low-risk nature of the patch, I vote for it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message The Hermit Hacker 2001-03-14 19:16:00 Re: pgmonitor patch for query string
Previous Message Roland Roberts 2001-03-14 18:34:08 Re: Re: Week number