| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Gregory Stark <stark(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: CSStorm occurred again by postgreSQL8.2 |
| Date: | 2006-09-14 13:57:59 |
| Message-ID: | 28515.1158242279@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
I wrote:
> I see a bug though, which is that RecordSubTransactionAbort() calls
> GetCurrentTransactionId() before having verified that it needs to do
> anything. This means that we'll generate and then discard an XID
> uselessly in a failed subxact that didn't touch disk.
Well, it would be a bug except that RecordSubTransactionAbort isn't
called unless the current subxact has an XID. Perhaps a comment would
be appropriate but there's nothing to fix here.
I think Theo's problem is probably somewhere else, too --- apparently
it's not so much that TransactionIdIsCurrentTransactionId takes a long
time as that something is calling it lots of times with no check for
interrupt.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Browne | 2006-09-14 13:59:35 | Re: Release notes |
| Previous Message | Tom Lane | 2006-09-14 13:54:07 | Re: Interesting tight loop |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2006-09-14 14:22:22 | Re: CSStorm occurred again by postgreSQL8.2 |
| Previous Message | Tom Lane | 2006-09-14 13:40:50 | Re: CSStorm occurred again by postgreSQL8.2 |