Re: Allows for commands to be processed iteractively

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fernando Nasser <fnasser(at)redhat(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Allows for commands to be processed iteractively
Date: 2002-03-01 16:00:30
Message-ID: 28498.1014998430@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Fernando Nasser <fnasser(at)redhat(dot)com> writes:
> Allows for some commands to be processed iteractively.

This patch seems to be missing quite a lot, like the node struct
definition and backend/nodes/*.c support for CreateSchemaStmt.
Perhaps your intention was not to introduce that yet, but in that
case I'd suggest not adding any sign of it in this patch.

More to the point, though, what is the reason for restructuring
pg_exec_query_string this way? The patch doesn't make any sense
to me as presented. I should think that any effort needed for
CREATE SCHEMA would be over in parser/analyze.c; restructuring
pg_exec_query_string isn't going to help.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Fernando Nasser 2002-03-01 16:02:34 Re: Allows for commands to be processed iteractively
Previous Message Fernando Nasser 2002-03-01 14:03:53 Adds the parsing of a CREATE SCHEMA statement