| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Rename contrib module basic_archive to basic_wal_module |
| Date: | 2023-01-25 21:50:22 |
| Message-ID: | 2848918.1674683422@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> I wanted to merge basic_archive and basic_recovery because there's a decent
> chunk of duplicated code.
Would said code likely be duplicated into non-test uses of this feature?
If so, maybe you ought to factor it out into a common location. I agree
with Robert's point that basic_wal_module is a pretty content-free name.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-01-25 21:58:01 | Re: pgsql: Rename contrib module basic_archive to basic_wal_module |
| Previous Message | Nathan Bossart | 2023-01-25 21:34:51 | Re: pgsql: Rename contrib module basic_archive to basic_wal_module |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-01-25 21:58:01 | Re: pgsql: Rename contrib module basic_archive to basic_wal_module |
| Previous Message | Peter Eisentraut | 2023-01-25 21:43:30 | Re: to_hex() for negative inputs |