| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Subject: | Re: compiler warning with VS 2017 |
| Date: | 2017-05-05 16:47:07 |
| Message-ID: | 28486.1494002827@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> writes:
> On 05/05/17 16:56, Tom Lane wrote:
>> So the comment should be something like "if the column is unchanged,
>> we should not attempt to access its value beyond this point. To
>> help catch any such attempts, set the string to NULL" ?
> Yes that sounds about right. We don't get any data for unchanged TOAST
> columns (that's limitation of logical decoding) so we better not touch them.
OK. I just made it say "we don't get the value of unchanged columns".
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-05-05 17:01:27 | Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling) |
| Previous Message | Tom Lane | 2017-05-05 16:29:54 | Re: what's up with IDENTIFIER_LOOKUP_EXPR? |