Re: Fix a typo in pg_rotate_logfile

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix a typo in pg_rotate_logfile
Date: 2024-02-14 15:04:49
Message-ID: 2839851.1707923089@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> On 14 Feb 2024, at 11:35, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> That said, pgAdmin III has been out of support for many years, and as far as I know, it (and similarly old versions of EDB's PEM which was based on it) were the only consumers of adminpack. I would not be sad to see it removed entirely

> Searching on Github and Debian Codesearch I cannot find any reference to anyone
> using any function from adminpack. With pgAdminIII being EOL it might be to
> remove it now rather than be on the hook to maintain it for another 5 years
> until v17 goes EOL. It'll still be around for years in V16->.

Works for me.

> Attached is a diff to show what it would look like to remove adminpack (catalog
> version bump omitted on purpose to avoid conflicts until commit).

I don't see any references you missed, so +1.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2024-02-14 15:31:16 Re: 035_standby_logical_decoding unbounded hang
Previous Message Melanie Plageman 2024-02-14 14:47:20 Re: BitmapHeapScan streaming read user and prelim refactoring