Re: AW: AW: Could turn on -O2 in AIX

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu>
Cc: Zeugswetter Andreas SB <ZeugswetterA(at)wien(dot)spardat(dot)at>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: AW: AW: Could turn on -O2 in AIX
Date: 2000-11-20 17:55:47
Message-ID: 28396.974742947@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu> writes:
> Is the original issue support for 0x10... as the smallest integer, as
> opposed to -MAX_INT? As long as we continue to map the "reserved values"
> to the upper and lower range of allowed values so they are unlikely to
> appear under normal circumstances, the change should be OK.

I think that the original problem was that Andreas was seeing a compiler
codegen bug on AIX, having to do with the comparison
foo > INT_MIN
generated by the AbsoluteTimeIsReal macro. I think he was seeing that
the compiler insisted on generating an unsigned compare, explicit casts
to signed datatypes notwithstanding :-(.

The proposed fix was to recode the macro's test as foo != INT_MIN,
thereby avoiding the issue of whether the comparison is signed or not.
To do that, we needed to make NOSTART_ABSTIME be defined as INT_MIN
on all platforms, not only AIX. That seemed like a good general-purpose
approach to me anyway, since the intended meaning of 0x80000000 was very
unclear otherwise.

regards, tom lane

PS: I'm quite sure that I'd explicitly cc'd you on the prior discussion.
If you didn't see it, then you've lost personal mail, not only pghackers
traffic...

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message 'Larry Rosenman' 2000-11-20 18:01:10 Re: err, XLOG/UW711/cc/Doesn't compile.
Previous Message Mikheev, Vadim 2000-11-20 17:46:39 RE: err, XLOG/UW711/cc/Doesn't compile.