| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EINTR in ftruncate() |
| Date: | 2022-07-14 15:24:49 |
| Message-ID: | 2834561.1657812289@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> ... but now I'm wondering if we should be more defensive and possibly
> even save/restore the mask.
+1, sounds like a more future-proof solution.
> Originally I discounted that because I
> thought I had to go through PG_SETMASK for portability reasons, but on
> closer inspection, I don't see any reason not to use sigprocmask
> directly in Unix-only code.
Seems like the thing to do is to add a suitable operation to the
pqsignal.h API. We could leave it unimplemented for now on Windows,
and then worry what to do if we ever need it in that context.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-14 15:27:24 | Re: EINTR in ftruncate() |
| Previous Message | Bruce Momjian | 2022-07-14 15:15:26 | Re: First draft of the PG 15 release notes |