| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Paul Ramsey <pramsey(at)cleverelephant(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Pg18 Recursive Crash |
| Date: | 2024-12-18 23:10:00 |
| Message-ID: | 2830028.1734563400@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Wed, 18 Dec 2024 at 23:45, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>> Maybe we need to backpatch passing NULL instead of &TTSOpsMinimalTuple
>> to ExecBuildGroupingEqual() in BuildTupleHashTableExt(). Something
>> like the attached patch.
> I've attached a more formal patch for this and I've also now done a
> bit more research and experimentation as to why we didn't notice this
> for so long.
I suspect that another key reason for the lack of reports is that
it's an assertion failure only, with no consequences in production
builds. So ordinary users issuing such a query wouldn't notice.
> I propose to quickly do a master-only follow-up commit to use the
> inputOps instead of NULL in BuildTupleHashTableExt (Basically Tom's
> patch from [1])
LGTM.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2024-12-18 23:18:25 | Re: Can rs_cindex be < 0 for bitmap heap scans? |
| Previous Message | Tom Lane | 2024-12-18 23:06:28 | Re: Regression tests fail on OpenBSD due to low semmns value |