| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: poll: CHECK TRIGGER? |
| Date: | 2012-04-04 16:32:03 |
| Message-ID: | 28287.1333557123@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> I don't think I'm getting my point across by explaining, so here's a
> modified version of the patch that does what I was trying to say.
Minor side point: some of the diff noise in this patch comes from
s/copy_plpgsql_datum/plpgsql_copy_plpgsql_datum/, which seems entirely
useless. The name already contains "plpgsql", and even if it didn't,
there is no particular reason for plpgsql to worry about polluting
global symbol namespace. Nothing else resolves against its symbols
anyway, at least not on any platform we claim to support. I would
therefore also argue against the other renamings like
s/exec_move_row/plpgsql_exec_move_row/.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2012-04-04 16:39:08 | Re: poll: CHECK TRIGGER? |
| Previous Message | Robert Haas | 2012-04-04 16:30:52 | Re: invalid search_path complaints |