| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_control read error message |
| Date: | 2018-05-18 14:22:29 |
| Message-ID: | 28273.1526653349@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> On 18/05/18 14:32, Magnus Hagander wrote:
>> If pg_control is for some reason empty, we give an error messagfe like:
>> 2018-05-18 13:24:03.342 CEST [19697] PANIC: could not read from control
>> file: Success
>> Which is, uh, wrong -- it's definitely not successful.
>> Obviously this is a state where the user is fairly screwed anyway, but we
>> should give a better message.
>> Attached is a patch that does this. Reasonable?
> Looks good to me.
Only comment I have is that I think there's similar shortcuts in a lot
of places :-(
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-05-18 14:28:12 | Re: Postgres 11 release notes |
| Previous Message | Michael Paquier | 2018-05-18 14:04:14 | Re: [PATCH] Use access() to check file existence in GetNewRelFileNode(). |