Re: use GUC for cmdline

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Marko Kreen <marko(at)l-t(dot)ee>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: use GUC for cmdline
Date: 2001-06-21 23:50:44
Message-ID: 28267.993167444@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Marko Kreen <marko(at)l-t(dot)ee> writes:
>> This seems like an appropriate fix. I would recommend doing the same
>> with all the option switch settings that are protected with "if
>> (secure)". This is not a hack: essentially it says we will treat
>> options passed to the postmaster with -o as postmaster-time options.

> - if (secure)
> - SetConfigOption("shared_buffers", optarg, ctx, true);
> + SetConfigOption("shared_buffers", optarg, secure_ctx, true);

Uh, removing the security checks is NOT what I had in mind. Wasn't
my example clear enough?

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Dave Cramer 2001-06-22 00:33:59 Re: Re: [ADMIN] High memory usage [PATCH]
Previous Message Marko Kreen 2001-06-21 23:13:12 Re: use GUC for cmdline