Re: Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module
Date: 2017-09-19 19:21:26
Message-ID: 28191.1505848886@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 09/19/2017 11:11 AM, Tom Lane wrote:
>> Actually, after looking closer, my advice is just to drop the new
>> test cases involving accented letters. It surprises me not in the
>> least that those would have nonportable behavior: probably, some
>> locales will case-fold them and some won't.

> Actually, it now looks to me like the problem is we forgot to tell
> postgres that this data is in utf8. The problem appears to resolve (at
> least on my CentOS test box, where I reproduced the buildfarm error) if
> I add
> set client_encoding = 'utf8';
> to the sql file.

That took care of one source of problems, but I wouldn't have expected it
to resolve all the problems ... and it didn't.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2017-09-19 19:22:18 Re: Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module
Previous Message Andres Freund 2017-09-19 19:20:32 Re: pgsql: Make new crash restart test a bit more robust.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2017-09-19 19:22:18 Re: Re: [COMMITTERS] pgsql: Add citext_pattern_ops for citext contrib module
Previous Message Joshua D. Drake 2017-09-19 19:21:06 Re: PG 10 release notes