[PATCH] Add UPDATE WHERE OFFSET IN clause

From: Böszörményi Zoltán <zboszor(at)pr(dot)hu>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: postgres(at)cybertec(dot)at
Subject: [PATCH] Add UPDATE WHERE OFFSET IN clause
Date: 2022-02-07 05:59:51
Message-ID: 2818f875-0eda-7040-637d-801806fdaf60@pr.hu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

A couple of years ago I was working on PostgreSQL
features and extensions. Some of them was in ECPG,
mainly in the area of improving Informix compatibility.

One of the patchsets I invented was the cursor readahead
support to improve performance in ECPG which used FETCH N.
This work was published at
https://github.com/zboszor/ecpg-readahead/commits

However, there was one use case for this patchset actually
decreased performance, namely if the cursor was used to
modify rows via UPDATE WHERE CURRENT OF. It was because
the cursor position on the server side was different from
the application so the ECPG readahead code had to use
MOVE then UPDATE WHERE CURRENT OF.

I brewed this idea for a while and yesterday I decided
to do something about it and here's the (admittedly, limited)
result. I added a new PostgreSQL extension to the UPDATE syntax:

UPDATE ... WHERE OFFSET n IN cursor;

This new syntax changes the feature disparity between
FETCH N and UPDATE WHERE CURRENT OF that existed in
PostgreSQL forever.

I only implemented this for cursors that use SELECT FOR UPDATE.
This part was quite straightforward to implement.

The behaviour of this syntax is as follows:
* the offset value may be 0 or negative, since it is a virtual
index into the rows returned by the last FETCH statement
and negative indexes are felt natural relative to the
cursor position and the cursor direction
* for offset value 0, the behaviour is identical to WHERE CURRENT OF
* negative indexes allow UPDATEs on previous rows even if
the cursor reached the end of the result set

I need clues for how to extend this for cursors that aren't
using FOR UPDATE queries, if it's possible at all.

Please, review.

Best regards,
Zoltán Böszörményi

Attachment Content-Type Size
0001-Add-UPDATE-.-WHERE-OFFSET-IN-clause.patch text/x-patch 16.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Valli Annamalai 2022-02-07 06:06:17 Query choosing Bad Index Path
Previous Message Etsuro Fujita 2022-02-07 05:50:01 Re: postgres_fdw: commit remote (sub)transactions in parallel during pre-commit