| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | pgsql-patches(at)postgreSQL(dot)org |
| Subject: | Re: Proposed patch for sequence-renaming problems |
| Date: | 2005-10-01 21:01:51 |
| Message-ID: | 28112.1128200511@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Here's an updated version of the patch. There's now just one nextval()
function, taking regclass, and backwards compatibility is handled
through an implicit text-to-regclass cast. Existing dumps will not see
any behavioral changes because nextval('foo') will be dumped as
nextval('foo'::text), but new entries of "nextval('foo')" will be
captured as regclass constants instead.
I noted that this version caused a couple more regression tests to fail;
for instance, the constraints test was expecting that it could drop and
recreate a sequence that was referenced by a default expression spelled
as "nextval('foo')". So we are paying for improved ease of use by
taking a larger backwards-compatibility risk than the original patch
did.
Last call for objections ...
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| seq-regclass-2.patch.gz | application/octet-stream | 10.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-10-01 21:13:40 | Re: [PATCHES] Proposed patch for sequence-renaming problems |
| Previous Message | Roger Hand | 2005-10-01 19:51:08 | Re: [HACKERS] Query in SQL statement |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-10-01 21:13:40 | Re: [PATCHES] Proposed patch for sequence-renaming problems |
| Previous Message | Bruce Momjian | 2005-10-01 19:28:58 | Re: [PATCHES] Proposed patch for sequence-renaming problems |