Re: pgsql: Fix ts_headline() edge cases for empty query and empty search te

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix ts_headline() edge cases for empty query and empty search te
Date: 2023-04-06 22:04:01
Message-ID: 2810776.1680818641@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

I wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> On 2023-04-06 19:52:55 +0000, Tom Lane wrote:
>>> Fix ts_headline() edge cases for empty query and empty search text.

>> Unfortunately there appears to be some portability issue with this. Causes a
>> test output difference on macos.

> Huh ... looking.

It's not about macOS, it's about that build script using
-DRANDOMIZE_ALLOCATED_MEMORY, which causes coerce_type() to
call tsqueryin() twice. So you get the bleat twice. Ugh.

I can work around it in these test cases by using to_tsquery()
instead of just "''::tsquery", but maybe we should rethink
something.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-04-06 22:14:37 pgsql: Stabilize just-added regression test cases.
Previous Message Tom Lane 2023-04-06 21:47:32 Re: pgsql: Fix ts_headline() edge cases for empty query and empty search te