Re: pgsql: Improve error handling in RemovePgTempFiles().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Improve error handling in RemovePgTempFiles().
Date: 2018-01-08 01:41:45
Message-ID: 28071.1515375705@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

I wrote:
> Hmmm ... actually, in the recursive call case, it wouldn't be that
> awful to ignore ENOENT either; if a directory goes away between being
> stat'd and being opened, you'd still get a log message about rmdir
> failure at the caller level. So maybe we should just do your
> second alternative as-is (ie, code as above but without missing_ok).
> Having an explicit control parameter seems marginally clearer but
> I'm not sure it's buying anything meaningful. Thoughts?

Hearing no comments, I did it the first way.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2018-01-08 02:16:08 Re: pgsql: Improve error handling in RemovePgTempFiles().
Previous Message Tom Lane 2018-01-08 01:40:57 pgsql: Back off chattiness in RemovePgTempFiles().