| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Stark <gsstark(at)mit(dot)edu> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Abhijit Menon-Sen <ams(at)oryx(dot)com> |
| Subject: | Re: Nearing final release? |
| Date: | 2004-10-16 22:41:05 |
| Message-ID: | 2806.1097966465@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Greg Stark <gsstark(at)mit(dot)edu> writes:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> * synchonize supported encodings and docs
> Is this Abhijit's patch to add PQprepare() and PQsendPrepare()?
No ... does it look like it?
> I'm not sure whether the patch he sent is adequate, I looked at it
> myself and was a bit skeptical. But he said my concerns were
> misplaced.
[ looks... ] The patch is definitely broken as-is, because it changes
the application-visible behavior of existing functions --- in particular
PQsendQueryParams() followed by PQgetResult() will now return a bogus
additional PGresult. I think the cleanest solution is probably to add a
state flag indicating whether ParseComplete should generate a PGresult
or not.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dann Corbit | 2004-10-16 23:04:30 | Re: Nearing final release? |
| Previous Message | Tom Lane | 2004-10-16 22:22:57 | Re: win32 pg_autovacuum make error |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2004-10-17 05:10:14 | Re: Nearing final release? |
| Previous Message | Greg Stark | 2004-10-16 21:42:46 | Re: Nearing final release? |