From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Peter Galbavy <peter(dot)galbavy(at)knowtion(dot)net>, pgsql-ports(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] openbsd 3.2, postgresql 7.3beta3 and openssl 'e_os.h' include |
Date: | 2002-11-07 18:49:40 |
Message-ID: | 28017.1036694980@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-ports |
I said:
> Anyway, get_last_socket_error() seems exactly equivalent to our macro
> SOCK_ERRNO in libpq/libpq-int.h. AFAICT, the uses of it in our
> code are these:
> /home/postgres/pgsql/src/backend/libpq/be-secure.c:
> errno = get_last_socket_error();
> /home/postgres/pgsql/src/backend/libpq/be-secure.c:
> errno = get_last_socket_error();
> /home/postgres/pgsql/src/interfaces/libpq/fe-secure.c:
> SOCK_ERRNO = get_last_socket_error();
> /home/postgres/pgsql/src/interfaces/libpq/fe-secure.c:
> SOCK_ERRNO = get_last_socket_error();
> and I think every one of these is bogus and should be removed.
> At best they're no-ops.
> If that is the only use of e_os.h stuff then we can stop including
> the file ...
These were indeed the only uses of e_os.h symbols. I have removed them
and the #includes.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-11-07 19:15:29 | Re: RC1 on Friday? |
Previous Message | Alvaro Herrera | 2002-11-07 18:47:23 | Re: Outstanding patches |
From | Date | Subject | |
---|---|---|---|
Next Message | Larry Rosenman | 2002-11-07 21:17:28 | Re: [HACKERS] PostgreSQL supported platform report and a |
Previous Message | Larry Rosenman | 2002-11-07 17:23:13 | Re: [HACKERS] PostgreSQL supported platform report and a |