Re: Annoying build warnings from latest Apple toolchain

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Annoying build warnings from latest Apple toolchain
Date: 2023-10-05 17:37:38
Message-ID: 2800037.1696527458@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> I think you can just pass c_args directly to executable() here, I think adding
> c_args to default_bin_args would be a bad idea.

Hm. IIUC that would result in an error if someone did try to
put some c_args into default_bin_args, and I didn't think it would
be appropriate for this code to fail in such a case. Still, I see
there are a bunch of other ways to inject globally-used compilation
flags, so maybe you're right that it'd never need to happen.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-10-05 18:34:00 Re: New WAL record to detect the checkpoint redo location
Previous Message Andres Freund 2023-10-05 17:31:47 Re: Annoying build warnings from latest Apple toolchain