Re: pgsql: Add pg_partition_root to display top-most parent of a partition

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add pg_partition_root to display top-most parent of a partition
Date: 2019-03-22 04:28:19
Message-ID: 27e4501a-ae56-94e4-1524-d509f048d61c@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2019/03/22 13:12, Michael Paquier wrote:
> On Fri, Mar 22, 2019 at 01:09:23PM +0900, Amit Langote wrote:
>> /* Fetch the top-most parent */
>> ancestors = get_partition_ancestors(relid);
>>
>> Maybe, the patch should update this comment to say "Fetch the list of
>> ancestors".
>
> Perhaps so. Note that actually the list is fetched to grab the
> top-most parent from it, so it sort of makes sense?

It looked fine before, but the new lines added by patch makes it look
wrong/misplaced somehow.

Thanks,
Amit

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-03-22 05:13:49 Re: pgsql: Add pg_partition_root to display top-most parent of a partition
Previous Message Amit Langote 2019-03-22 04:16:16 Re: pgsql: Add pg_partition_root to display top-most parent of a partition