Re: pgsql: Add 'basebackup_to_shell' contrib module.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: 2022-03-30 19:19:48
Message-ID: 279981.1648667988@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-03-30 13:16:47 -0400, Robert Haas wrote:
>> On Wed, Mar 30, 2022 at 1:11 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>>> My concern is about the quote in the middle of the path, not about quoting at all... I.e. the ' should be after /tmp_install, not before.

>> Makes no difference. We know that the string /tmp_install contains no
>> shell metacharacters, so why does it need to be in quotes? I would've
>> probably written it the way it is here, rather than what you are
>> proposing.

> It looks ugly, and it can't be copy-pasted as easily. Seems I'm alone on this,
> so I'll leave it be...

FWIW, I agree with Andres that I'd probably have put the quote
at the end. But Robert is right that it's functionally equivalent;
so I doubt it's worth changing.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2022-03-30 19:45:19 pgsql: Document basebackup_to_shell.required_role.
Previous Message Andres Freund 2022-03-30 19:12:51 Re: pgsql: Add 'basebackup_to_shell' contrib module.

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2022-03-30 19:21:05 Re: explain_regress, explain(MACHINE), and default to explain(BUFFERS) (was: BUFFERS enabled by default in EXPLAIN (ANALYZE))
Previous Message Nathan Bossart 2022-03-30 19:18:38 Re: Patch to avoid orphaned dependencies