| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Marko Kreen <markokr(at)gmail(dot)com>, Tollef Fog Heen <tollef(dot)fog(dot)heen(at)collabora(dot)co(dot)uk>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: TCP keepalive support for libpq |
| Date: | 2010-06-23 20:56:07 |
| Message-ID: | 27969.1277326567@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> On Wed, Jun 23, 2010 at 5:32 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> OK, here's a new version with several fewer bugs.
> Since valid values for keepalives parameter are 0 and 1, its field size should
> be 1 rather than 10.
Right ... although maybe it should be considered a boolean and not an
int at all?
> In this case, you can check the value of keepalives parameter by seeing
> conn->keepalives[0] instead of using strtol() in useKeepalives().
I disagree with that idea, though. The field size has nothing to do
with most of the possible sources of the variable's value ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-06-23 21:22:35 | Re: TCP keepalive support for libpq |
| Previous Message | Tom Lane | 2010-06-23 20:54:00 | Re: Cannot cancel the change of a tablespace |