Re: pg_hba.conf.sample wording improvement

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_hba.conf.sample wording improvement
Date: 2021-04-28 14:20:14
Message-ID: 2796699.1619619614@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> I propose the attached patch to shake up the wording in the connection
> type section of pg_hba.conf.sample a bit. After the hostgssenc part was
> added on, the whole thing became a bit wordy, and it's also a bit
> inaccurate for example in that the current wording for "host" appears to
> say that it does not apply to GSS-encrypted connections.

+1 for revising it in this general way. I notice you omitted "TCP/IP"
from the last line though:

+# - "hostnogssenc" is a not GSSAPI-encrypted socket

which doesn't seem consistent.

Another thought is to switch the phrase order:

+# - "local" is a Unix-domain socket
+# - "host" is a TCP/IP socket (encrypted or not)
+# - "hostssl" is a TCP/IP socket that is SSL-encrypted
+# - "hostnossl" is a TCP/IP socket that is not SSL-encrypted
+# - "hostgssenc" is a TCP/IP socket that is GSSAPI-encrypted
+# - "hostnogssenc" is a TCP/IP socket that is not GSSAPI-encrypted

I'm not wedded to that idea, but it seems to help reduce random
variations between the wordings of these lines.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2021-04-28 14:21:04 Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY
Previous Message Greg Stark 2021-04-28 14:16:35 Re: Skip temporary table schema name from explain-verbose output.