| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] path toward faster partition pruning |
| Date: | 2018-03-22 04:07:05 |
| Message-ID: | 278abb39-d784-bc18-c8cc-c42e3e1e89d1@lab.ntt.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018/03/20 21:41, David Rowley wrote:
> On 21 March 2018 at 00:07, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> Attached is further revised version.
>
> In the 0004 patch I see:
>
> @@ -1439,6 +1441,10 @@ inheritance_planner(PlannerInfo *root)
> if (IS_DUMMY_PATH(subpath))
> continue;
>
> + /* Add the current parent's RT index to the partitioned rels set. */
> + partitioned_relids = bms_add_member(partitioned_relids,
> + appinfo->parent_relid);
>
> This seems to execute regardless of if the target relation is a
> partitioned table or an inheritance parent. I think there needs to be
> a condition so you only do this when planning for partitioned tables.
Oops, that's quite wrong. Will fix, thanks.
Regards,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2018-03-22 04:34:51 | Re: ON CONFLICT DO UPDATE for partitioned tables |
| Previous Message | Michael Paquier | 2018-03-22 03:53:49 | Re: faster testing with symlink installs |