Re: pure parsers and reentrant scanners

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> I started committing the cube and seg pieces. There were a couple of
> complaints from the buildfarm, like
> segscan.c:348:15: error: redefinition of typedef 'yyscan_t' is a C11
> feature [-Werror,-Wtypedef-redefinition]
> typedef void* yyscan_t;
> ...
> (Also, we should probably figure out a way to get these warnings before
> things hit the buildfarm.)

Interestingly, while sifaka shows that, its sibling indri doesn't.
Same compiler, same CFLAGS. I think the relevant difference must
be that sifaka is using a much older Bison version (the Apple-supplied
2.3, versus MacPorts' up-to-the-minute version). I think that sort of
thing is exactly why we have the buildfarm. It would not be
reasonable to expect CI to cover that many cases. Trying to do so
would just make CI slow enough that we'd start looking for a new test
phase to put in front of it.

regards, tom lane