Re: GiST: PickSplit and multi-attr indexes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)stack(dot)net>
Subject: Re: GiST: PickSplit and multi-attr indexes
Date: 2004-11-14 23:54:19
Message-ID: 27866.1100476459@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Neil Conway <neilc(at)samurai(dot)com> writes:
> If I understand the code correctly, GiST will only pass the first
> attribute of each index tuple to the user-defined PickSplit method when
> it wants to split a node. (see circa line 1269 of gist.c)

> Is this a wise design decision?

It's probably just a hangover from the days when GiST didn't support
multi-column indexes at all. I agree it should be changed. But note
you will then have to cope with NULL values.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-11-15 00:18:22 Re: IpcSemaphoreLock/Unlock and proc_exit on 7.2.6
Previous Message Tom Lane 2004-11-14 23:43:43 Re: German-style quotes in the source file