From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Silence some Coverity warnings and improve code consistency. |
Date: | 2021-04-12 14:01:01 |
Message-ID: | 2786228.1618236061@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> On 11.04.21 23:02, Tom Lane wrote:
>> ... or more accurately, with an LL constant, which is not project
>> style. Make all of these use INT64CONST(), as we do elsewhere.
> I think this style could be considered obsolete because C99 requires LL
> constants, and configure checks for it.
I'm not worried about whether compilers will take LL --- after all, we
also make free use of "long long" these days. I am worried that
it does not necessarily equate to int64 exactly.
In any case, I'm not a fan of TIMTOWTDI. If we want to remove
[U]INT64CONST in favor of [U]LL, we should do so across the board,
so as to maintain a consistent project style.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2021-04-12 15:25:30 | Re: pgsql: SQL-standard function body |
Previous Message | Peter Eisentraut | 2021-04-12 13:46:10 | pgsql: Fix files references in nls.mk |