| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, mb(dot)alzouabi(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18245: pg_restore accepts same output file name as input file name |
| Date: | 2023-12-14 14:50:01 |
| Message-ID: | 2781744.1702565401@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
> On Wed, Dec 13, 2023 at 09:44:26AM +0100, Daniel Gustafsson wrote:
>> Something like the attached (untested) sketch should be enough I think.
> I'm wondering if it would be worth adding some canonicalize_path() calls while
> at it, ISTM that such mistakes are likely to happen when invoking pg_restore
> manually, so having slightly different wording for the exact same file wouldn't
> surprising.
I'm a little dubious about the value of this; but if we're going to do
it, comparing post-canonicalize_path strings does seem like the right
way.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Zhilin | 2023-12-14 16:18:11 | [BUG] false positive in bt_index_check in case of short 4B varlena datum |
| Previous Message | Tom Lane | 2023-12-14 14:43:45 | Re: BUG #18247: Integer overflow leads to negative width |