Re: Add -k/--link option to pg_combinebackup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Israel Barth Rubio <barthisrael(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add -k/--link option to pg_combinebackup
Date: 2025-03-18 20:38:13
Message-ID: 278129.1742330293@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Mar 18, 2025 at 1:55 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> 10s added to every check-world run doesn't sound "cheap" to me.

> Really? If you're sensitive to the time the tests take to run, maybe
> use 'meson test' rather than 'make check-world'?

FTR, what I actually use is

make -s -j10 check-world >/dev/null

which I like because I don't see any output unless there's a problem.
On my machine, that took right about 2 minutes for a long time;
lately it's crept up to about 2:15 which is already annoying me.
Admittedly an additional 10-second test might not add much to that
due to parallelism, but then again it might; it's hard to tell how
much slop we have in the parallel scheduling.

Anyway, I'm totally fine with finding a way to allow pgindent
checking to be included, as long as I can opt out of that.
I don't especially want to see buildfarm cycles going into it
on every animal, either. If there's any test we have that ought
to be completely deterministic, it'd be this one.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2025-03-18 20:40:36 Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Previous Message Bruce Momjian 2025-03-18 20:35:29 Re: Increase default maintenance_io_concurrency to 16